Skip to content

fix: let server to communicate with the browser #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 27, 2019
Merged

fix: let server to communicate with the browser #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13ea9eb
commit
grabbou Feb 27, 2019
6347735
Fix lint
grabbou Feb 27, 2019
ee3d5d1
Remove default flag
grabbou Feb 27, 2019
3857e51
commit
grabbou Feb 27, 2019
19425f8
Revert type changes
grabbou Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/cli/src/server/middleware/getDevToolsMiddleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@
import launchChrome from '../util/launchChrome';
import logger from '../../util/logger';

function launchChromeDevTools(host, port, args = '') {
const debuggerURL = `http://${host}:${port}/debugger-ui${args}`;
function launchChromeDevTools(port, args = '') {
const debuggerURL = `http://localhost:${port}/debugger-ui${args}`;
logger.info('Launching Dev Tools...');
launchChrome(debuggerURL);
}

function launchDevTools({ host, port, watchFolders }, isChromeConnected) {
function launchDevTools({ port, watchFolders }, isChromeConnected) {
// Explicit config always wins
const customDebugger = process.env.REACT_DEBUGGER;
if (customDebugger) {
customDebugger({ watchFolders, customDebugger });
} else if (!isChromeConnected()) {
// Dev tools are not yet open; we need to open a session
launchChromeDevTools(host, port);
launchChromeDevTools(port);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/server/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default {
},
{
command: '--host [string]',
default: '0.0.0.0',
default: '',
},
{
command: '--watchFolders [list]',
Expand Down