Skip to content

Conversation

@krizzu
Copy link
Member

@krizzu krizzu commented Mar 28, 2019

Summary:

Small change regarding upgrade command.
Before, if name value in package.json has changed since you init'ed a project, react-native upgrade would fail. This is because directory paths in diffing were selected based on that name value.

Now, we check if names (from package.json and app.json) are different, and if so, use the one from app.json (to keep name value in package.json untouched).

Test Plan:

Probably green CI should be sufficient.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try using link utilities to infer the project name? We're deprecating app.json and would like not to use it :)

@krizzu
Copy link
Member Author

krizzu commented Apr 9, 2019

Closing in favor of #299

@krizzu krizzu closed this Apr 9, 2019
@krizzu krizzu deleted the upgrade-name branch April 9, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants