feat: make legacy link use new configuration

.circleci/config.yml

@@ -14,11 +14,11 @@ jobs:
           at: ~/react-native-cli
       - restore_cache:
           keys:
-            - dependencies-{{ checksum "package.json" }}
-            - dependencies-
+            - v2-dependencies-{{ checksum "package.json" }}
+            - v2-dependencies-
       - run: yarn install
       - save_cache:
-          key: dependencies-{{ checksum "package.json" }}
+          key: v2-dependencies-{{ checksum "package.json" }}
           paths:
             - node_modules
       - persist_to_workspace:

.flowconfig

@@ -43,6 +43,7 @@ module.ignore_non_literal_requires=true
 all=warn
 unnecessary-optional-chain=off
 dynamic-export=off
+unsafe-getters-setters=off
 
 # There is an ESLint rule for this
 unclear-type=off

e2e/__tests__/uninstall.test.js

@@ -38,7 +38,7 @@ test('uninstall fails when package is not installed', () => {
   });
   const {stderr, code} = run(DIR, ['uninstall', pkg]);
 
-  expect(stderr).toContain(`Project "${pkg}" is not a react-native library`);
+  expect(stderr).toContain(`Failed to unlink "${pkg}".`);
   expect(code).toBe(1);
 });
 

packages/cli/src/cliEntry.js

@@ -18,7 +18,6 @@ import {getCommands} from './commands';
 import init from './commands/init/initCompat';
 import assertRequiredOptions from './tools/assertRequiredOptions';
 import logger from './tools/logger';
-import findPlugins from './tools/findPlugins';
 import {setProjectDir} from './tools/PackageManager';
 import pkgJson from '../package.json';
 import loadConfig from './tools/config';
@@ -38,15 +37,17 @@ const handleError = err => {
   if (commander.verbose) {
     logger.error(err.message);
   } else {
+    // Some error messages (esp. custom ones) might have `.` at the end already.
+    const message = err.message.replace(/\.$/, '');
     logger.error(
-      `${err.message}. ${chalk.dim(
+      `${message}. ${chalk.dim(
         `Run CLI with ${chalk.reset('--verbose')} ${chalk.dim(
           'flag for more details.',
         )}`,
       )}`,
     );
   }
-  logger.debug(err.stack);
+  logger.debug(chalk.dim(err.stack));
   process.exit(1);
 };
 
@@ -184,7 +185,7 @@ async function setupAndRun() {
 export default {
   run,
   init,
-  findPlugins,
+  loadConfig,
 };
 
-export {run, init, findPlugins};
+export {run, init, loadConfig};

packages/cli/src/commands/info/__tests__/info.test.js

@@ -1,31 +1,24 @@
 // @flow
 import info from '../info';
 import logger from '../../../tools/logger';
+import loadConfig from '../../../tools/config';
 
 jest.mock('../../../tools/logger', () => ({
   info: jest.fn(),
   error: jest.fn(),
   log: jest.fn(),
 }));
 
-const ctx = {
-  root: '',
-  reactNativePath: '',
-  dependencies: {},
-  platforms: {},
-  commands: [],
-  haste: {
-    platforms: [],
-    providesModuleNodeModules: [],
-  },
-};
+jest.mock('../../../tools/config');
 
 beforeEach(() => {
   jest.resetAllMocks();
 });
 
+const config = loadConfig();
+
 test('prints output without arguments', async () => {
-  await info.func([], ctx, {});
+  await info.func([], config, {});
   expect(logger.info).toHaveBeenCalledWith(
     'Fetching system and libraries information...',
   );

packages/cli/src/commands/init/init.js

@@ -100,9 +100,9 @@ function createProject(projectName: string, options: Options, version: string) {
   return createFromReactNativeTemplate(projectName, version, options.npm);
 }
 
-export default async function initialize(
+export default (async function initialize(
   [projectName]: Array<string>,
-  context: ContextT,
+  _context: ContextT,
   options: Options,
 ) {
   validateProjectName(projectName);
@@ -125,4 +125,4 @@ export default async function initialize(
     logger.error(e.message);
     fs.removeSync(projectName);
   }
-}
+});

packages/cli/src/commands/install/install.js

@@ -11,15 +11,19 @@ import type {ContextT} from '../../tools/types.flow';
 import logger from '../../tools/logger';
 import * as PackageManager from '../../tools/PackageManager';
 import link from '../link/link';
+import loadConfig from '../../tools/config';
 
 async function install(args: Array<string>, ctx: ContextT) {
   const name = args[0];
 
   logger.info(`Installing "${name}"...`);
   PackageManager.install([name]);
 
+  // Reload configuration to see newly installed dependency
+  const newConfig = loadConfig();
+
   logger.info(`Linking "${name}"...`);
-  await link.func([name], ctx, {platforms: undefined});
+  await link.func([name], newConfig, {platforms: undefined});
 
   logger.success(`Successfully installed and linked "${name}"`);
 }