feat: use config in run-ios to resolve project location
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: --------- While working on #241 we discovered some flaky tests. This diff aims to fix those. It also updates Jest to 24.6 which comes with pretty nice perf improvements. Test Plan: ---------- Green CI
Member
Author
|
To be rebased and merged after #281 is merged. |
Member
|
mind rebasing to master (it produces awful merge conflicts, so probably easier to open it once again) |
grabbou
force-pushed
the
feat/run-ios-rn-tester
branch
from
18e7693 to
47e4d67
Compare
grabbou
changed the title
run-iosrun-ios to resolve project location
grabbou
force-pushed
the
feat/run-ios-rn-tester
branch
from
47e4d67 to
18e7693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now, iOS path is hardcoded to
ios, which makes it impossible to runRNTester"out-of-the-box".This is a slight change that updates the default value of the option.
Note: We should probably also move the "xcworkspace" information to the config instead of it being here, but this can be done in a follow-up.
Fixes #12
Partially fixes (not close yet): #143
Test Plan:
Run
react-native run-iosinreact-nativeroot. It should just work.