Skip to content

fix: prevent unnecessary actions if build failed #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2019
Merged

fix: prevent unnecessary actions if build failed #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17df729
fix: prevent unnecessary actions if build failed
ifsnow Apr 17, 2019
aa6a4eb
throw CLIError instead of using boolean
ifsnow Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/platform-android/src/commands/runAndroid/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
isPackagerRunning,
logger,
getDefaultUserTerminal,
CLIError,
} from '@react-native-community/cli-tools';

// Verifies this is an Android project
Expand Down Expand Up @@ -149,8 +150,11 @@ function buildApk(gradlew) {
execFileSync(gradlew, ['build', '-x', 'lint'], {
stdio: [process.stdin, process.stdout, process.stderr],
});
} catch (e) {
logger.error('Could not build the app, read the error above for details.');
} catch (error) {
throw new CLIError(
'Could not build the app, read the error above for details',
error,
);
}
}

Expand Down