Skip to content

Check ios-deploy installation before proceeding to build on device #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 19, 2019
Merged

Check ios-deploy installation before proceeding to build on device #332

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01e83da
Check `ios-deploy` installation before proceeding to build on device
Apr 18, 2019
941d40f
Merge branch 'master' of https://github.com/react-native-community/cl…
Apr 19, 2019
06ae293
Improve info & error messages when running iOS
Apr 19, 2019
034f4ba
Use `CLIError` instead of `Error`
Apr 19, 2019
3668ae6
Fix typo
Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions packages/platform-ios/src/commands/runIOS/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,20 @@ async function runOnSimulator(xcodeProject, scheme, args: FlagsT) {
}

async function runOnDevice(selectedDevice, scheme, xcodeProject, args: FlagsT) {
const isIOSDeployInstalled = child_process.spawnSync(
'ios-deploy',
['--version'],
{encoding: 'utf8'},
);

if (isIOSDeployInstalled.error) {
throw new CLIError(
`Failed to install the app on the device because we couldn't execute the "ios-deploy" command. Please install it by running "${chalk.bold(
'npm install -g ios-deploy',
)}" and try again.`,
);
}

const appName = await buildProject(
xcodeProject,
selectedDevice.udid,
Expand All @@ -214,12 +228,14 @@ async function runOnDevice(selectedDevice, scheme, xcodeProject, args: FlagsT) {
);

if (iosDeployOutput.error) {
logger.error(
'** INSTALLATION FAILED **\nMake sure you have ios-deploy installed globally.\n(e.g "npm install -g ios-deploy")',
throw new CLIError(
`Failed to install the app on the device. We've encountered an error in "ios-deploy" command: ${
iosDeployOutput.error.message
}`,
);
} else {
logger.info('** INSTALLATION SUCCEEDED **');
}

return logger.success('Installed the app on the device.');
}

function buildProject(xcodeProject, udid, scheme, args: FlagsT) {
Expand Down