imp: do not set permissions #357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
requested changes
Apr 26, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
I don't think this is a complete solution. For example binary files are still written with source permission (e.g. 0o444 which throws with EACCESS).
How about we keep reading srcPermissions, write files with default mode (0o666) and then run fs.chmod(srcPermissions)?
Member
|
FYI I just got another error while copying Pods folder - you can find my report on Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some files inside
Podshave onlyreadpermissions. Do not explicitly set permissions for saved file.Test Plan:
Initialise new project with pods in the template.
cc @grabbou @krizzu @thymikee