Skip to content

fix: Ensure that bundle URL origin matches debugger page origin #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2019
Merged

fix: Ensure that bundle URL origin matches debugger page origin #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/cli/src/commands/server/debugger-ui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,15 @@
connectToDebuggerProxy();

async function getBlobUrl(url) {
return await window.deltaUrlToBlobUrl(url.replace('.bundle', '.delta'));
// Ensure that the bundle URL has the same origin as this webpage so that
// the same-origin policy lets us fetch it
const urlObject = new URL(url, location);
const relativeUrl = urlObject.pathname.replace('.bundle', '.delta') +
urlObject.search +
urlObject.hash;
const localUrl = new URL(relativeUrl, location).toString();

return await window.deltaUrlToBlobUrl(localUrl);
}
})();
</script>
Expand Down