Skip to content

fix: incorrect condition for upgrade newer version check #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix: incorrect condition for upgrade newer version check #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cli/src/commands/upgrade/__tests__/upgrade.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ test('errors when older version passed', async () => {
expect(logger.error).toBeCalledWith(
`Trying to upgrade from newer version "${currentVersion}" to older "${olderVersion}"`,
);
await upgrade.func(['0.57.10'], ctx, opts);
expect(logger.error).not.toBeCalledWith(
`Trying to upgrade from newer version "${currentVersion}" to older "0.57.10"`,
);
}, 60000);

test('warns when dependency upgrade version is in semver range', async () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/commands/upgrade/upgrade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,13 @@ const getVersionToUpgradeTo = async (argv, currentVersion, projectDir) => {
return null;
}

if (currentVersion > newVersion) {
if (semver.gt(currentVersion, newVersion)) {
logger.error(
`Trying to upgrade from newer version "${currentVersion}" to older "${newVersion}"`,
);
return null;
}
if (currentVersion === newVersion) {
if (semver.eq(currentVersion, newVersion)) {
const {
dependencies: {'react-native': version},
} = require(path.join(projectDir, 'package.json'));
Expand Down