Skip to content

chore: Standarise fetch in CLI #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 16, 2019
Merged

chore: Standarise fetch in CLI #463

merged 12 commits into from
Jul 16, 2019

Conversation

@Esemesek
Copy link
Member

@Esemesek Esemesek commented Jul 3, 2019 •
edited
Loading

Summary:

Standardise fetch calls in CLI.

Fixes #423

Test Plan:

  • - Make sure that tests pass
  • - Make sure that commands using new fetch function work on real world example

@Esemesek Esemesek requested a review from thymikee July 3, 2019 14:35
@Esemesek Esemesek requested a review from grabbou as a code owner July 3, 2019 14:35
thymikee
thymikee reviewed Jul 3, 2019
View reviewed changes
thymikee
thymikee reviewed Jul 3, 2019
View reviewed changes
thymikee
thymikee reviewed Jul 3, 2019
View reviewed changes
@thymikee thymikee changed the title imp: Standarise fetch in CLI chore: Standarise fetch in CLI Jul 4, 2019
@thymikee
Copy link
Member

thymikee commented Jul 8, 2019

ping

@Esemesek
Copy link
Member Author

Esemesek commented Jul 9, 2019 •
edited
Loading

@thymikee I'll finish this today C:

thymikee
thymikee reviewed Jul 16, 2019
View reviewed changes
@thymikee thymikee merged commit 948776e into master Jul 16, 2019
@thymikee thymikee deleted the fetch branch July 16, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thymikee thymikee thymikee approved these changes

@grabbou grabbou Awaiting requested review from grabbou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Standardize how we make HTTP requests?

3 participants

@Esemesek @thymikee