Skip to content

chore: remove REACT_NATIVE_APP_ROOT, use --watchFolders #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2020
Merged

chore: remove REACT_NATIVE_APP_ROOT, use --watchFolders #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
546f053
chore: remove `watchFolders` from the CLI
grabbou Jan 30, 2020
d035234
Update CONTRIBUTING.md
grabbou Jan 30, 2020
19aa05c
remove findSymlinkedModules
thymikee Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ npm config set registry https://registry.npmjs.org/

## Running `start` command

In order for symlinks to work correctly when running `start` locally, set REACT_NATIVE_APP_ROOT as the root folder of your cli project:
In order for linked dependencies to work correctly when running `start` locally, set `--watchFolders` with a path to the root folder of the CLI project:

```
REACT_NATIVE_APP_ROOT=path/to/cli node path/to/cli/packages/cli/build/bin.js start
node path/to/cli/packages/cli/build/bin.js start --watchFolders path/to/cli
```

## Running CLI with React Native from the source
Expand Down
354 changes: 0 additions & 354 deletions packages/cli/src/tools/__tests__/findSymlinkedModules-test.js
View file
Open in desktop

This file was deleted.

Loading