only handle cacheEnable when app is active#3104
Merged
christopherdro merged 1 commit intoreact-native-maps:masterfrom Oct 17, 2019
Merged
only handle cacheEnable when app is active#3104christopherdro merged 1 commit intoreact-native-maps:masterfrom
christopherdro merged 1 commit intoreact-native-maps:masterfrom
Conversation
Collaborator
|
LGTM |
Contributor
|
We identified the bug and while researching a fix, i tried this and it worked. 👍 |
christopherdro
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
#3100
MapView went black in iOS (apple map) with
cacheEnablewhen switching to other apps or goes to backgroundHow did you test this PR?
Local test on my phone.
Step 1. Open mapview with cacheEnable
Step 2. Switch to other apps then switch back -> mapview still visible
Step 3. Hide app to background then open again -> mapview still visible