Protect against null Location in FusedLocationSource#3345
Merged
christopherdro merged 2 commits intoreact-native-maps:masterfrom Mar 17, 2020
netshade:protect-against-null-location-in-fused-location-source
Merged
Protect against null Location in FusedLocationSource#3345christopherdro merged 2 commits intoreact-native-maps:masterfrom netshade:protect-against-null-location-in-fused-location-source
christopherdro merged 2 commits intoreact-native-maps:masterfrom
netshade:protect-against-null-location-in-fused-location-source
Conversation
Collaborator
|
LGTM @christopherdro 🐽 |
christopherdro
approved these changes
Mar 17, 2020
netshade
deleted the
protect-against-null-location-in-fused-location-source
branch
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…ps#3345) * protect against null location in map view * Update FusedLocationSource.java Co-authored-by: Christopher Dro <hello@blick-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
#3344
How did you test this PR?
Tested on Android Emulator w/ Detox on a CI server where this was previously occurring. The crash does not recur.