Add download link to all files

[guhungry]

Feature Request

Add download link to all files

Why it is needed

Sometime files can be replace directly (.flowconfig) or in case of new file (.eslintrc.js). Download and replace it would be faster.

Possible implementation

Add download link just like binary file

[pvinis]

To be honest I feel like non-binary files don't need to be downloaded. I would prefer to have a "copy" button that copies the text, but this happens so infrequently that I don't think it's a problem.

Also, we encourage people to know and understand the changes, and even if you copy paste, you will still see something. Just downloading a file or many, I don't see this bringing any good.

Does that make sense?

[guhungry]

Umm, make sense. But how about link to VIEW source file in github. So anyone can see full content of the file and decide how to update it.

Sometimes copy chunk of continuous text is not easy.

PS. I understand the limitation of HTML display vs copy text
PS2. Github's diff view also have this copy issue

[lucasbento]

🤔 I do like the option to view the entire source of the file.

@guhungry: do you think it should go directly to the raw file like GitHub does?

By the way, having a "copy" button to copy all the contents of the file will be slightly tricky to implement as we don't have the content of the file in hand, therefore we will need to first fetch all the content and then copy it to the clipboard. We could do it if proved to be efficient 🙂

[guhungry]

@guhungry: do you think it should go directly to the raw file like GitHub does?

Either one is fine. I prefer normal view because it has syntax highlight. To download just click Raw button.

For copy feature copy this chunk would be great since data is already in diff.

[lucasbento]

@pvinis: what do you think about this?

[pvinis]

Hm, with all this info, yea, maybe it's nice to just put a link to the raw file on github. I'm not psyched about this, but let's do it and if later we find a better way, we decide.

[lucasbento]

@guhungry: I just noticed that the library we use has a prop to optimize what you select in the changes and I opened a PR to add it: #55, with this you can select changes on each column separately.

Thank you for bringing this up 😄

[lucasbento]

With #55, do you think "downloading files" or "copying chunks automatically" are still needed, @guhungry & @pvinis?

[pvinis]

Personally, I would never "download" a file from the diff.

If you guys think the option is important, then let's add it and let the people who were gonna use it, use it. I'm just afraid to make it "easier", when people start downloading and replacing their files, and then not actually looking at their own diffs after the upgrade and compare. The upgrade unfortunatelly needs care and attention, and I am hesitant to give people a footgun when they don't need it, even if they might ask for it.

But I'm open to be convinced otherwise :D

[lucasbento]

@pvinis: definitely agree with that!

[guhungry]

Working manual selecttion is more critical for me. For copy chunk is jus nice to have.

For download just as @pvinis said.