Skip to content
This repository was archived by the owner on Mar 30, 2022. It is now read-only.

Conversation

@HariAcidReign
Copy link
Contributor

Fixes #128

After Fix

Dark Mode:
image

Light Mode:
image

Reasoning:

There are 3 methods of solving this issue.

  • Create another logo.png with the Hackathon and the ReactNative Logo (top part of the image) in black for light mode and do conditional rendering. This way, you can make the top part of the image black in light mode, and white in dark mode (as it is now)
  • Change the color of the entire image based on the toggle state. Implementation (as far as I have tried) looks like this:
    style={[styles.Image, value ? styles.darkmode : styles.lightmode]}
    The problem with this approach is that by doing this, in light mode the entire logo is blue but in dark mode, it remains as it is (top part is white and "STARTER" is in blue) and this looks weird when transitioning
  • This is the ideal and lightweight method to solve this issue. Make the color for both modes the same (blue). But this time, the logo is clearly visible in both dark and light modes and looks consistent when toggling (as it was before)

Note: The blue gradient used here is the exact same as the one used in "STARTER"

Open to suggestions, and willing to implement them accordingly 🙌🏻

@flyingcircle flyingcircle merged commit d4327ec into react-native-elements:next Mar 15, 2021
@HariAcidReign HariAcidReign deleted the color-logo branch March 15, 2021 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with light theme

2 participants