Fix #105 where onTaskRemoved was no longer being called#112
Merged
Guichaguri merged 1 commit intodoublesymmetry:devfrom Jan 8, 2018
puckey:dev
Merged
Fix #105 where onTaskRemoved was no longer being called#112Guichaguri merged 1 commit intodoublesymmetry:devfrom puckey:dev
Guichaguri merged 1 commit intodoublesymmetry:devfrom
puckey:dev
Conversation
Collaborator
|
Thank you :) |
|
Sorry but not perfect fix, when you open the App again it will show The playback is not initialized. You need to kill app once again before player back to work normal. I tried to change code like this if(manager.shouldStopWithApp()) { But it force the app when I kill the app :(, btw when open app again player work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See more on the difference between passing
0andBIND_AUTO_CREATEtobindService: https://stackoverflow.com/questions/14746245/use-0-or-bind-auto-create-for-bindservices-flagSeeing as
Context.BIND_AUTO_CREATEstarts the service for us automatically, we need to do it manually by callingcontext.startService(intent);