Skip to content

Fix #105 where onTaskRemoved was no longer being called#112

Merged
Guichaguri merged 1 commit intodoublesymmetry:devfrom
puckey:dev
Jan 8, 2018
Merged

Fix #105 where onTaskRemoved was no longer being called#112
Guichaguri merged 1 commit intodoublesymmetry:devfrom
puckey:dev

Conversation

@puckey
Copy link
Copy Markdown
Collaborator

@puckey puckey commented Jan 8, 2018

See more on the difference between passing 0 and BIND_AUTO_CREATE to bindService : https://stackoverflow.com/questions/14746245/use-0-or-bind-auto-create-for-bindservices-flag

Seeing as Context.BIND_AUTO_CREATE starts the service for us automatically, we need to do it manually by calling context.startService(intent);

@Guichaguri
Copy link
Copy Markdown
Collaborator

Thank you :)

@donghungx
Copy link
Copy Markdown

Sorry but not perfect fix, when you open the App again it will show The playback is not initialized. You need to kill app once again before player back to work normal.

I tried to change code like this

if(manager.shouldStopWithApp()) {
stopSelf();
manager.destroyPlayer();
stopForeground(true);
manager.onServiceDestroy();
manager = null;
}

But it force the app when I kill the app :(, btw when open app again player work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants