testId for picker item is not working

[mohamed-ikram]

i have checked it in appium desktop and the test id not working

`import { Picker } from '@react-native-community/picker';
                                 <Picker style={styles.yearPickerContainer}
                                    selectedValue={this.state.selectedYear}
                                    onValueChange={(service) => (this.setState({ selectedYear: service }))}
                                    itemStyle={{ color: "#000000", fontSize: 26 }} 
                                    {...testProps('yearPicker')}
                                    >
                                    <Picker.Item label="Java" value="java" testID="java" />
                                    <Picker.Item label="JavaScript" value="js" testID="javass"/>
                                </Picker>`

the version I'm using is:
"react": "^16.13.1",
"react-native": "^0.63.3",
"@react-native-community/picker": "^1.6.6",

in picker item props in Picker.js

type PickerItemProps = $ReadOnly<{|
  /**
   * Text to display for this item.
   */
  label: string,

  /**
   * The value to be passed to picker's `onValueChange` callback when
   * this item is selected. Can be a string or an integer.
   */
  value?: ?(number | string),

  /**
   * Color of this item's text.
   * @platform android
   */
  color?: ColorValue,

  /**
   * Used to locate the item in end-to-end tests.
   */
  testID?: string,
|}>;

so there is no problem with version

[jwboardman]

I'm having the same problem. Shouldn't testID be added here in PickerIOS.ios.js so it can be properly set in state?

static getDerivedStateFromProps(props: Props): State {
    let selectedIndex = 0;
    const items = [];
    React.Children.toArray(props.children).forEach(function (child, index) {
      if (child.props.value === props.selectedValue) {
        selectedIndex = index;
      }
      items.push({
        value: child.props.value,
        label: child.props.label,
        textColor: processColor(child.props.color),
>>>        testID: child.props.testID,  <<<
      });
    });
    return {selectedIndex, items};
  }

[jwboardman]

Here's a patch for adding the testID to each item. Local testing with Xcode's Accessibility Inspector shows that there is now a value in the Identifier field after this patch, whereas before it was undefined.

issue-180.patch.zip

[jwboardman]

What's the process here to get issues looked at? Our QA automation team is waiting for this fix.

[mohamed-ikram]

I'll ask my qe team and get back to u they said they have some idea but not by test id they used some other method

[jwboardman]

Thanks - I was really referring to the react-native-picker collaborators. I attached a patch to fix this issue since I have no permission to do a PR.

[mohamed-ikram]

Ok great

[jwboardman]

Maybe the common thing is to just fork the repo? 84 forks...

[jwboardman]

ok finally figured out how to PR :)

[Naturalclar]

Closed with #189 thanks to @jwboardman �:tada:

[mohamed-ikram]

@jwboardman @Naturalclar hello i have checked test id for Picker item doesnt show up
my code is

`import { Picker } from '@react-native-community/picker';
                                 <Picker style={styles.yearPickerContainer}
                                    selectedValue={this.state.selectedYear}
                                    onValueChange={(service) => (this.setState({ selectedYear: service }))}
                                    itemStyle={{ color: "#000000", fontSize: 26 }} 
                                    {...testProps('yearPicker')}
                                    >
                                    <Picker.Item label="Java" value="java" testID="java" />
                                    <Picker.Item label="JavaScript" value="js" testID="javass"/>
                                </Picker>`

i have checked in picker.d.ts test id is there

export interface PickerItemProps {
label: string;
value?: ItemValue;
color?: string;
testID?: string;
}

do i need to send test id differently or what its for android i have attached image

package version:
"react": "^16.13.1",
"react-native": "^0.63.3",
"@react-native-picker/picker": "^1.9.8",

device-
android-oneplus-A5000
version-10

[jwboardman]

I specifically fixed it for iOS. My QA team did not report a problem with Android so I didn't look at that.

…

On Fri, Dec 25, 2020 at 1:53 PM Mohamed Ikram ***@***.***> wrote: @jwboardman <https://github.com/jwboardman> @Naturalclar <https://github.com/Naturalclar> hello i have checked test id for Picker item doesnt show up my code is `import { Picker } from ***@***.***/picker'; <Picker style={styles.yearPickerContainer} selectedValue={this.state.selectedYear} onValueChange={(service) => (this.setState({ selectedYear: service }))} itemStyle={{ color: "#000000", fontSize: 26 }} {...testProps('yearPicker')} > <Picker.Item label="Java" value="java" testID="java" /> <Picker.Item label="JavaScript" value="js" testID="javass"/> </Picker>` i have checked in picker.d.ts test id is there export interface PickerItemProps { label: string; value?: ItemValue; color?: string; testID?: string; } do i need to send test id differently or what its for android i have attached image [image: Screenshot (4)] <https://user-images.githubusercontent.com/62332326/103141294-89b41600-4718-11eb-8997-51a317f6e469.png> package version: "react": "^16.13.1", "react-native": "^0.63.3", ***@***.***/picker": "^1.9.8", device- android-oneplus-A5000 version-10 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#180 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATWZHIOMJX7TXCKT4FVHF3SWTUSZANCNFSM4UHS63MQ> .

-- *John Boardman**Sr. Consultant* *Keyhole Software* Direct: (816) 916-3536 <8169163536> jboardman@keyholesoftware.com | keyholesoftware.com <http://www.keyholesoftware.com/>

[mohamed-ikram]

ok thanks @Naturalclar can u please check this

[mohamed-ikram]

@jwboardman hello do u have any idea how to make it work and can u please check my qe team is kinda waiting for this