set the audio mode to voip

[danjenkins]

this seems to make two way audio happen on my s8

fixes #7

[manuquentin]

Thanks !

[geraintwhite]

This works for inbound calls but not outbound.

[danjenkins]

How strange - I've tested it and it works fine on my s8

…

On Tue, 29 Jan 2019, 14:28 Geraint White, ***@***.***> wrote: This works for inbound calls but not outbound. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO1rZiSr6upUCVKGbb4bM97v0_cMDx_ks5vIFqIgaJpZM4aX-5_> .

[geraintwhite]

Calling setAudioModeIsVoip(true) after setDialing() in onCreateOutgoingConnection works for outgoing calls.

[geraintwhite]

NB: outgoing calls are only possible with this library after #5 is merged.

[danjenkins]

AHHH, yes I'm not using connection manager for outgoing calls as I'm not using the PR in #5

So this PR is good for now (as in the current state of master), and PR #5 needs to make it work for outgoing

[geraintwhite]

So shall I add setAudioModeIsVoip(true) in #5 too?

[danjenkins]

@grit96 yeah in my mind, my PR fixed things for the current state of the master branch

If you're adding outgoing in #5 then your fix needs to go into #5 - make sense?