This repository was archived by the owner on May 26, 2019. It is now read-only.
Callback for displayIncomingCall method #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarkalyk
force-pushed
the
display-incoming-call-callback
branch
from
6e2a4ee to
786d28a
Compare
ianlin
reviewed
Mar 6, 2018
index.js
Outdated
| RNCallKitDidDisplayIncomingCall, | ||
| (data) => { callback(data.error); } | ||
| )); | ||
| } |
There was a problem hiding this comment.
I would suggest that not adding listeners every time you call displayIncomingCall() as it would ended up having so many listeners without removing them. A better way to do this is just like how we add event listeners in addEventListener() function; users only need to register listener once and they can choose to remove listeners anytime they want, e.g. in componentWillUnmount().
There was a problem hiding this comment.
Good point. I'll fix it today.
|
@ianlin Please, review :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful callback to know whether or not
reportNewIncomingCallhas succeeded and handle actions accordingly.