Skip to content

Added getIsWiredHeadsetPluggedIn to bridge methods #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2017
Merged

Added getIsWiredHeadsetPluggedIn to bridge methods #42

merged 2 commits into from
Aug 8, 2017

Conversation

@masaori
Copy link
Contributor

@masaori masaori commented Jul 31, 2017

I added native bridge method which lets me know the state of "isWiredHeadsetPluggedIn" even right after launch the app.

@zxcpoiu
Copy link
Member

zxcpoiu commented Aug 3, 2017

thanks.

here is 2 points:

  1. if android is not implemented yet, add a if Platform.OS === 'ios' .... else log not implemented yet

  2. would you mind change to promise style aligns with another functions? EX:
    swift: https://github.com/zxcpoiu/react-native-incall-manager/blob/master/ios/RNInCallManager/RNInCallManager.swift#L701
    js: https://github.com/zxcpoiu/react-native-incall-manager/blob/master/index.js#L145

@masaori
Copy link
Contributor Author

masaori commented Aug 3, 2017

Gotcha! Will do both of them.
Just a moment please.

@masaori
Copy link
Contributor Author

masaori commented Aug 8, 2017

@zxcpoiu
I amended these as your instruction.
Could you check please?

@zxcpoiu zxcpoiu merged commit dd6a4f7 into react-native-webrtc:master Aug 8, 2017
@zxcpoiu
Copy link
Member

zxcpoiu commented Aug 8, 2017

thanks mate!

zxcpoiu added a commit that referenced this pull request Aug 8, 2017
@zxcpoiu
release 2.2.0
3a79c04 
a2d710e wakelock: acquire lock during whole ringtone and start process  ( zxcpoiu 2017-08-08 20:33:48 +0800)
dd6a4f7 Added getIsWiredHeadsetPluggedIn to bridge methods (#42)  ( Masaori Hirono 2017-08-08 22:05:53 +0900)
29f748b handle RN 0.47 breaking change (createJSModules removed from ReactPackage)  ( Pete 2017-08-02 12:54:10 +1200)
9370858 Update some codes syntax to swift3 which causes errors  ( Toshinori Tsugita 2017-05-25 14:20:06 +0900)
1564c32 Fix broken Markdown headings  ( Santiago Castro 2017-04-16 16:40:34 -0300)
b24eeab Added iOS support for controlling system flash  ( Stepan Votava 2017-02-23 14:23:31 +0100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masaori @zxcpoiu