This repository was archived by the owner on Feb 25, 2020. It is now read-only.
Reset this.gestureX on manual setting #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
added a commit
to satya164/react-native-tab-view
that referenced
this pull request
May 15, 2019
The gesture amount is used to calculate the next index which can interfere with manual navigation. Similar to react-navigation/drawer#70 Co-authored-by: osdnk <micosa97@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On very fast close drawer and then clicking "open drawer" no action happened
The reason was that value was badly calculated bc it has considered not position and velocity of prev gesture.
Changes
On changing the value manually I reset
gestureX. It led to not passing condition in node passed tothis.transitionTo