fix: don't keep unfocused header backgrounds visible

satya164 · satya164 · commit bd269ef3f1a0 · 2019-10-22T05:07:16.000+02:00
diff --git a/src/TransitionConfigs/HeaderStyleInterpolators.tsx b/src/TransitionConfigs/HeaderStyleInterpolators.tsx
@@ -106,7 +106,12 @@ export function forFade({
     leftButtonStyle: { opacity },
     rightButtonStyle: { opacity },
     titleStyle: { opacity },
-    backgroundStyle: { opacity: current.progress },
+    backgroundStyle: {
+      opacity: interpolate(progress, {
+        inputRange: [0, 1, 1.9, 2],
+        outputRange: [0, 1, 1, 0],
+      }),
+    },
   };
 }
 
diff --git a/src/navigators/__tests__/__snapshots__/NestedNavigator.test.tsx.snap b/src/navigators/__tests__/__snapshots__/NestedNavigator.test.tsx.snap
@@ -383,7 +383,7 @@ Array [
                                 "top": 0,
                               },
                               Object {
-                                "opacity": NOOP {},
+                                "opacity": undefined,
                               },
                             ]
                           }
@@ -523,7 +523,7 @@ Array [
               "top": 0,
             },
             Object {
-              "opacity": NOOP {},
+              "opacity": undefined,
             },
           ]
         }
diff --git a/src/navigators/__tests__/__snapshots__/StackNavigator.test.tsx.snap b/src/navigators/__tests__/__snapshots__/StackNavigator.test.tsx.snap
@@ -215,7 +215,7 @@ Array [
               "top": 0,
             },
             Object {
-              "opacity": NOOP {},
+              "opacity": undefined,
             },
           ]
         }
@@ -554,7 +554,7 @@ Array [
               "top": 0,
             },
             Object {
-              "opacity": NOOP {},
+              "opacity": undefined,
             },
           ]
         }

Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ Array [`
`383`	`383`	`"top": 0,`
`384`	`384`	`},`
`385`	`385`	`Object {`
`386`		`- "opacity": NOOP {},`
	`386`	`+ "opacity": undefined,`
`387`	`387`	`},`
`388`	`388`	`]`
`389`	`389`	`}`
`@@ -523,7 +523,7 @@ Array [`
`523`	`523`	`"top": 0,`
`524`	`524`	`},`
`525`	`525`	`Object {`
`526`		`- "opacity": NOOP {},`
	`526`	`+ "opacity": undefined,`
`527`	`527`	`},`
`528`	`528`	`]`
`529`	`529`	`}`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ Array [`
`215`	`215`	`"top": 0,`
`216`	`216`	`},`
`217`	`217`	`Object {`
`218`		`- "opacity": NOOP {},`
	`218`	`+ "opacity": undefined,`
`219`	`219`	`},`
`220`	`220`	`]`
`221`	`221`	`}`
`@@ -554,7 +554,7 @@ Array [`
`554`	`554`	`"top": 0,`
`555`	`555`	`},`
`556`	`556`	`Object {`
`557`		`- "opacity": NOOP {},`
	`557`	`+ "opacity": undefined,`
`558`	`558`	`},`
`559`	`559`	`]`
`560`	`560`	`}`