fix: don't fade incoming background when fading header

satya164 · satya164 · commit f3a26888c534 · 2019-10-16T15:29:22.000+02:00
diff --git a/src/TransitionConfigs/HeaderStyleInterpolators.tsx b/src/TransitionConfigs/HeaderStyleInterpolators.tsx
@@ -106,7 +106,7 @@ export function forFade({
     leftButtonStyle: { opacity },
     rightButtonStyle: { opacity },
     titleStyle: { opacity },
-    backgroundStyle: { opacity },
+    backgroundStyle: { opacity: current.progress },
   };
 }
 
diff --git a/src/navigators/__tests__/__snapshots__/NestedNavigator.test.tsx.snap b/src/navigators/__tests__/__snapshots__/NestedNavigator.test.tsx.snap
@@ -383,7 +383,7 @@ Array [
                                 "top": 0,
                               },
                               Object {
-                                "opacity": undefined,
+                                "opacity": NOOP {},
                               },
                             ]
                           }
@@ -523,7 +523,7 @@ Array [
               "top": 0,
             },
             Object {
-              "opacity": undefined,
+              "opacity": NOOP {},
             },
           ]
         }
diff --git a/src/navigators/__tests__/__snapshots__/StackNavigator.test.tsx.snap b/src/navigators/__tests__/__snapshots__/StackNavigator.test.tsx.snap
@@ -215,7 +215,7 @@ Array [
               "top": 0,
             },
             Object {
-              "opacity": undefined,
+              "opacity": NOOP {},
             },
           ]
         }
@@ -554,7 +554,7 @@ Array [
               "top": 0,
             },
             Object {
-              "opacity": undefined,
+              "opacity": NOOP {},
             },
           ]
         }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ export function forFade({`
`106`	`106`	`leftButtonStyle: { opacity },`
`107`	`107`	`rightButtonStyle: { opacity },`
`108`	`108`	`titleStyle: { opacity },`
`109`		`- backgroundStyle: { opacity },`
	`109`	`+ backgroundStyle: { opacity: current.progress },`
`110`	`110`	`};`
`111`	`111`	`}`
`112`	`112`
Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ Array [`
`383`	`383`	`"top": 0,`
`384`	`384`	`},`
`385`	`385`	`Object {`
`386`		`- "opacity": undefined,`
	`386`	`+ "opacity": NOOP {},`
`387`	`387`	`},`
`388`	`388`	`]`
`389`	`389`	`}`
`@@ -523,7 +523,7 @@ Array [`
`523`	`523`	`"top": 0,`
`524`	`524`	`},`
`525`	`525`	`Object {`
`526`		`- "opacity": undefined,`
	`526`	`+ "opacity": NOOP {},`
`527`	`527`	`},`
`528`	`528`	`]`
`529`	`529`	`}`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ Array [`
`215`	`215`	`"top": 0,`
`216`	`216`	`},`
`217`	`217`	`Object {`
`218`		`- "opacity": undefined,`
	`218`	`+ "opacity": NOOP {},`
`219`	`219`	`},`
`220`	`220`	`]`
`221`	`221`	`}`
`@@ -554,7 +554,7 @@ Array [`
`554`	`554`	`"top": 0,`
`555`	`555`	`},`
`556`	`556`	`Object {`
`557`		`- "opacity": undefined,`
	`557`	`+ "opacity": NOOP {},`
`558`	`558`	`},`
`559`	`559`	`]`
`560`	`560`	`}`