-
Notifications
You must be signed in to change notification settings - Fork 190
feat: allow specifying separate style interpolators in navigationOptions #155
feat: allow specifying separate style interpolators in navigationOptions #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Instead of adding this in navigationOptions, I'd move this prop entirely to NavigationStackOptions and remove it from NavigationConfig.
This means we also need to move the direction and transitionSpec options so it's possible to use a TransitionPreset in navigationOptions.
Edit: We should probably also rename direction option to transitionDirection to avoid ambiguity.
Edit: Or direction is fine. It's not just for transition, but both gesture and transition.
|
@satya164 I tried removing |
|
@satya164 I implemented removal of Default Unfortunately the problem with missing |
|
@tchayen I'll take care of it tomorrow. |
|
Thank you for updating the PR :D |
|
@satya164 it works. Pushing the commit. |
As @satya164 suggested in #154, instead of passing
navigationOptionsto interpolators, they can be allowed to specify their own interpolators.Custom interpolator, if defined, takes precedence over the one from
NavigationConfig. The rest of the logic stays the same.