Skip to content

Commit 2db75a2

Browse files
committed
Update the ESLint dependencies, and also tweak the no-multiple-empty-lines rules
Since multiple empty lines is virtually unused in the code-base, and the few cases that do exist look like "typos", let's enforce greater consistency here; please see https://eslint.org/docs/rules/no-multiple-empty-lines.
1 parent 25c7a8c commit 2db75a2

File tree

11 files changed

+4
-13
lines changed

11 files changed

+4
-13
lines changed

.eslintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
"new-cap": ["error", { "newIsCap": true, "capIsNew": false, }],
125125
"new-parens": "error",
126126
"no-array-constructor": "error",
127-
"no-multiple-empty-lines": ["error", { "max": 2, "maxEOF": 0, "maxBOF": 1, }],
127+
"no-multiple-empty-lines": ["error", { "max": 1, "maxEOF": 0, "maxBOF": 1, }],
128128
"no-new-object": "error",
129129
"no-tabs": "error",
130130
"no-trailing-spaces": ["error", { "skipBlankLines": false, }],

extensions/firefox/tools/l10n.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@
7676
}
7777
}
7878

79-
8079
// translate an HTML subtree
8180
function translateFragment(element) {
8281
element = element || document.querySelector("html");

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
"babel-preset-env": "^1.6.0",
1010
"core-js": "^2.5.1",
1111
"escodegen": "^1.9.0",
12-
"eslint": "^4.10.0",
13-
"eslint-plugin-mozilla": "^0.4.9",
14-
"eslint-plugin-no-unsanitized": "^2.0.1",
12+
"eslint": "^4.14.0",
13+
"eslint-plugin-mozilla": "^0.5.0",
14+
"eslint-plugin-no-unsanitized": "^2.0.2",
1515
"fancy-log": "^1.3.2",
1616
"gulp": "^3.9.1",
1717
"gulp-rename": "^1.2.2",

src/core/cff_parser.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ var CFFStandardStrings = [
9696
'Black', 'Bold', 'Book', 'Light', 'Medium', 'Regular', 'Roman', 'Semibold'
9797
];
9898

99-
10099
var CFFParser = (function CFFParserClosure() {
101100
var CharstringValidationData = [
102101
null,

src/core/evaluator.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1351,7 +1351,6 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
13511351
textContentItem.textRunBreakAllowed = false;
13521352
}
13531353

1354-
13551354
textContentItem.initialized = true;
13561355
return textContentItem;
13571356
}

src/core/font_renderer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,6 @@ var FontRendererFactory = (function FontRendererFactoryClosure() {
676676
},
677677
});
678678

679-
680679
return {
681680
create: function FontRendererFactory_create(font, seacAnalysisEnabled) {
682681
var data = new Uint8Array(font.data);

src/display/pattern_helper.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,6 @@ ShadingIRs.Mesh = {
251251
}
252252
}
253253

254-
255254
// Rasterizing on the main thread since sending/queue large canvases
256255
// might cause OOM.
257256
var temporaryPatternCanvas = createMeshCanvas(bounds, scale, coords,

src/display/webgl.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ var WebGLUtils = (function WebGLUtilsClosure() {
219219
var texture = createTexture(gl, layer, gl.TEXTURE0);
220220
var maskTexture = createTexture(gl, mask, gl.TEXTURE1);
221221

222-
223222
// Create a buffer and put a single clipspace rectangle in
224223
// it (2 triangles)
225224
var buffer = gl.createBuffer();

test/unit/function_spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,6 @@ describe('function', function() {
440440
});
441441
});
442442

443-
444443
describe('PostScriptCompiler', function() {
445444
function check(code, domain, range, samples) {
446445
var compiler = new PostScriptCompiler();

test/webbrowser.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,5 +261,4 @@ WebBrowser.create = function (desc) {
261261
return new WebBrowser(name, path);
262262
};
263263

264-
265264
exports.WebBrowser = WebBrowser;

0 commit comments

Comments
 (0)