feat: add useAsyncSetState #12
Conversation
|
We occasionally need this, like in our auth contexts |
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 58.14% 60.89% +2.75%
==========================================
Files 27 28 +1
Lines 270 289 +19
Branches 63 65 +2
==========================================
+ Hits 157 176 +19
Misses 113 113
Continue to review full report at Codecov.
|
src/useAsyncSetState.ts
Outdated
| setState(stateBefore => { | ||
| try { | ||
| let nextState: TState | ||
| if (typeof update === 'function') { |
There was a problem hiding this comment.
i don't suppose instanceof makes TS happy?
There was a problem hiding this comment.
it does but instanceof Function is weird
src/useAsyncSetState.ts
Outdated
|
|
||
| useEffect(() => { | ||
| resolvers.current.forEach(resolve => resolve(state)) | ||
| resolvers.current = [] |
There was a problem hiding this comment.
| resolvers.current = [] | |
| resolvers.current.length = 0; |
easier? :p
| // react won't re-render and effect will not resolve. If there are already | ||
| // resolvers queued, then it should be safe to assume an update will happen | ||
| if (!resolvers.current.length && Object.is(nextState, prevState)) { | ||
| resolve(nextState) |
There was a problem hiding this comment.
ok; you could also add another "should run resolve manually flag", but i guess eagerly resolving the first few is fine
There was a problem hiding this comment.
ah right in the case of a bunch of sets. yeah that's a good approach
No description provided.