Skip to content

fix: set crossOrigin prior to src #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2020
Merged

fix: set crossOrigin prior to src #31

merged 1 commit into from
May 14, 2020

Conversation

@ethanve
Copy link
Collaborator

@ethanve ethanve commented May 14, 2020

I think setting the src variable kicks off the request for the image without setting the CORS attribute

@ethanve ethanve requested a review from jquense May 14, 2020 15:49
@ethanve
Copy link
Collaborator Author

ethanve commented May 14, 2020

Yep. See https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_enabled_image#Starting_the_download

@ethanve ethanve merged commit 1d585ec into master May 14, 2020
@ethanve ethanve deleted the fix/image-cross-origin branch May 14, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taion taion taion approved these changes

@jquense jquense Awaiting requested review from jquense

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanve @taion