-
Couldn't load subscription status.
- Fork 7
Add the missing support of help texts to InputGroup (#663)
#667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
530fa09 to
6c23099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for help texts to the InputGroup component, allowing developers to provide additional guidance for grouped inputs. Previously, InputGroup only supported validation texts.
Key changes:
- Added
helpTextsprop toInputGroupfor displaying help messages - Modified
TextField,SelectField, andFileInputFieldto suppress their individual help texts when used within anInputGroup - Updated documentation and tests to reflect the new functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/InputGroup/InputGroup.jsx | Added helpTexts prop and rendering logic for help text list |
| src/components/InputGroup/InputGroup.module.scss | Added .helpText class selector to styling rules |
| src/components/TextField/TextField.jsx | Prevented help text rendering within InputGroup context and updated documentation |
| src/components/SelectField/SelectField.jsx | Prevented help text rendering within InputGroup context and updated documentation |
| src/components/FileInputField/FileInputField.jsx | Prevented help text and validation text rendering within InputGroup context and updated documentation |
| src/components/InputGroup/tests/InputGroup.spec.tsx | Added test coverage for help texts functionality |
| src/components/InputGroup/README.md | Added documentation section for help texts feature with examples |
| src/components/Button/README.md | Fixed spelling error in documentation |
Comments suppressed due to low confidence (2)
src/components/TextField/TextField.jsx:1
- The documentation incorrectly refers to 'help text' when it should say 'validation text'. This comment is describing the
validationTextprop behavior, not thehelpTextprop.
import PropTypes from 'prop-types';
src/components/SelectField/SelectField.jsx:1
- The documentation incorrectly refers to 'help text' when it should say 'validation text'. This comment is describing the
validationTextprop behavior, not thehelpTextprop.
import PropTypes from 'prop-types';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
`InputGroup` now supports the `helpTexts` prop. For `FileInputField`, `Select`, and `TextField`, help text is not rendered within the `InputGroup` context. The `helpTexts` prop of `InputGroup` must be used instead.
…xts to `InputGroup` (#663)
0d72efc to
1622cf1
Compare
InputGroupnow supports thehelpTextsprop.For
FileInputField,Select, andTextField, help text is not rendered within theInputGroupcontext. ThehelpTextsprop ofInputGroupmust be used instead.Closes #663.