Skip to content

Conversation

@weblogixx
Copy link
Member

Just updated the unit tests to use the new shallow rendering for react. The update involves many changes on different files and includes:

  • Updated packages for Babel (now uses 5.x instead of 4.x), Karma and webpack.
  • Removed the default karma-browser launchers and only included PhantomJS. After the update of grunt-karma the syntax of karma.conf.js has changed slightly, so if using them, you have to require them as plugins
  • Added minor performance improvements for unit tests (that one was easy, the karma config for webpack had not exclude for node_modules, adding this alone speeded the tests up roughly 4 seconds on my machine)
  • Updated unit tests to use new ES2015 syntax (because why not :)).

Note! The changes on unit tests are incompatible with the older release! That means that old projects that you add tests to will use the new defaults, but are NOT able to handle them. Therefore, old projects would need to be migrated manually.

Please have a look at the changes and tell me what you think about it.

newtriks added a commit that referenced this pull request Jul 2, 2015
@newtriks newtriks merged commit 49c9775 into react-webpack-generators:master Jul 2, 2015
@newtriks
Copy link
Member

newtriks commented Jul 2, 2015

Thanks @weblogixx

@weblogixx weblogixx deleted the feat-unittest branch September 21, 2015 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants