Skip to content

Updated CI Test Env #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 26, 2018
Merged

Updated CI Test Env #13

merged 18 commits into from
May 26, 2018

Conversation

@reactive-firewall
Copy link
Owner

@reactive-firewall reactive-firewall commented May 24, 2018 •
edited
Loading

@reactive-firewall reactive-firewall self-assigned this May 24, 2018
@codecov-io
Copy link

codecov-io commented May 25, 2018 •
edited by codecov bot
Loading

Codecov Report

Merging #13 into stable will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           stable    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          43     45    +2     
=====================================
+ Hits           43     45    +2
Impacted Files Coverage Δ
pythonrepo/pythonrepo.py 100% <100%> (ø) ⬆️
pythonrepo/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8867540...6ca62f4. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c0cd48f on master into 8867540 on stable.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c0cd48f on master into 8867540 on stable.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c0cd48f on master into 8867540 on stable.

@coveralls
Copy link

coveralls commented May 25, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6ca62f4 on master into 8867540 on stable.

@reactive-firewall
Changes to be committed:
e4c2410 
	modified:   .coveragerc
	 - [x] fixed regression (see #12)
	modified:   pythonrepo/__init__.py
         - [x] bummped version to 1.1.0 for 2018
	modified:   tests/test_usage.py
         - [x] #14 fixed code style
@reactive-firewall
Changes to be committed:
3120acb 
	modified:   tests/test_usage.py
         - [x] #15 fixed subtle default issue
@reactive-firewall
Changes to be committed:
06b4cc1 
	modified:   tests/test_usage.py
	 - [x] #19 Fixed by casting to string
@reactive-firewall
Changes to be committed:
b9568c3 
	modified:   tests/test_usage.py
	- [x] #16 Fixed subtle default value
@reactive-firewall
#18 Fixed by cating to string and #17 fixed subtle default value
54ba495
@reactive-firewall
#20 fixed import style
5cfc231
@reactive-firewall
#21 fixed subtle default
3399e15
@reactive-firewall
#22 fixed 8 Maintainability issues in tests\profiling.py
092effd
@reactive-firewall
#22 fixed 8 Maintainability issues in tests\profiling.py
a964000
@reactive-firewall
#22 fixed 8 Maintainability issues in tests\profiling.py regression
a17c0a2
@reactive-firewall
#22 fixed 8 Maintainability issues in tests\profiling.py regression p…
6ca62f4 
…art 2
reactive-firewall
reactive-firewall commented May 26, 2018
View reviewed changes
Copy link
Owner Author

@reactive-firewall reactive-firewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The essence of this PR is found in:
https://github.com/reactive-firewall/python-repo/pull/13/files#diff-354f30a63fb0907d4ad57269548329e3R21-R23
https://github.com/reactive-firewall/python-repo/pull/13/files#diff-354f30a63fb0907d4ad57269548329e3R50
https://github.com/reactive-firewall/python-repo/pull/13/files#diff-354f30a63fb0907d4ad57269548329e3R52
https://github.com/reactive-firewall/python-repo/pull/13/files#diff-354f30a63fb0907d4ad57269548329e3R54
https://github.com/reactive-firewall/python-repo/pull/13/files#diff-354f30a63fb0907d4ad57269548329e3R73-R78
https://github.com/reactive-firewall/python-repo/pull/13/files#diff-354f30a63fb0907d4ad57269548329e3R106-R108
👍

Other changes include code style fixes Issues #14 #15 #16 #17 #18 #19 #20 #21 #22 found by new CodeFactory integration 👍

Overall this PR greatly improves the quality of the code.
✅ Approved!

@reactive-firewall reactive-firewall merged commit 6ca62f4 into stable May 26, 2018
reactive-firewall added a commit that referenced this pull request May 26, 2018
@reactive-firewall
Merge branch 'master' into stable PR (#13)
d1e85e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@reactive-firewall reactive-firewall

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reactive-firewall @codecov-io @coveralls