Version Update #23
Merged
Version Update #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - if [ $TRAVIS_PYTHON_VERSION == "3.2" ] ; then echo "SKIP make test-tox" ; else make test-tox || exit $? ; fi ; | ||
| - make clean ; | ||
| - make clean || exit $? ; | ||
| - if [ $TRAVIS_PYTHON_VERSION == "3.2" ] || [ $TRAVIS_PYTHON_VERSION == "3.3" ] ; then echo "SKIP make test-tox" ; else make test-tox || exit $? ; fi ; |
Owner
Author
There was a problem hiding this comment.
This workaround helps fixes tox dependency on python 3.4+ from breaking 3.3 or older builds
also lines 180-181
| - if [ $TRAVIS_PYTHON_VERSION == "3.2" ] ; then echo "SKIP codecov" ; else codecov 2>/dev/null || true ; fi ; | ||
| - if [ $TRAVIS_OS_NAME == osx ] || [ $TRAVIS_PYTHON_VERSION == "3.2" ] ; then echo "SKIP code climate" ; else ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT || true ; fi ; | ||
| - if [ $TRAVIS_PYTHON_VERSION == "3.2" ] ; then echo "SKIP codecov" ; else codecov 2>/dev/null || true ; fi ; | ||
| - if [ $TRAVIS_OS_NAME == osx ] || [ $TRAVIS_PYTHON_VERSION == "3.2" ] || [ $TRAVIS_PYTHON_VERSION == "3.3" ] ; then echo "SKIP code climate" ; else ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT || true ; fi ; |
Owner
Author
There was a problem hiding this comment.
Same as line 172
| - if [ $TRAVIS_OS_NAME == osx ] || [ $TRAVIS_PYTHON_VERSION == "3.2" ] ; then echo "SKIP code climate" ; else ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT || true ; fi ; | ||
| - if [ $TRAVIS_PYTHON_VERSION == "3.2" ] ; then echo "SKIP codecov" ; else codecov 2>/dev/null || true ; fi ; | ||
| - if [ $TRAVIS_OS_NAME == osx ] || [ $TRAVIS_PYTHON_VERSION == "3.2" ] || [ $TRAVIS_PYTHON_VERSION == "3.3" ] ; then echo "SKIP code climate" ; else ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT || true ; fi ; | ||
| - if [ $TRAVIS_PYTHON_VERSION == "3.2" ] || [ $TRAVIS_PYTHON_VERSION == "3.3" ] ; then echo "SKIP codecov" ; else codecov 2>/dev/null || true ; fi ; |
Owner
Author
There was a problem hiding this comment.
same as line 172
| # List of patterns, relative to source directory, that match files and | ||
| # directories to ignore when looking for source files. | ||
| exclude_patterns = ['_build'] | ||
| exclude_patterns = ['_build', 'tests'] |
Owner
Author
There was a problem hiding this comment.
document tests separately ... not in template
|
|
||
|
|
||
| __version__ = """1.0.0""" | ||
| __version__ = """1.1.0""" |
| [metadata] | ||
| name = pythonrepo | ||
| version = 1.0.2 | ||
| version = 1.1.1 |
Codecov Report
@@ Coverage Diff @@
## stable #23 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 45 44 -1
=====================================
- Hits 45 44 -1
Continue to review full report at Codecov.
|
Owner
Author
|
👍 Automated Code review passed.
|
Owner
Author
|
Update: After investigating the CI Failure, I found no critical failure.
|
reactive-firewall
added a commit
that referenced
this pull request
Aug 24, 2018
* master: Fixed regression in CI env updates Posible fix for coverity scans and CI env updates #25 Reduced cognitive complexity by breaking up function into checks and work slightly #25 Fixed Exsesive Cognitive Complexity #24 Fixed Trailing Space #23 - minor typo fix #23 fix for regression bug #23 reduced code duplication as recommended by code climate workaround for broken python 3.3 env on travis version bump minor fixes to copyright fix for whitespace fix badges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.