Skip to content

Fix antipattern with static folder name #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2022
Merged

Fix antipattern with static folder name #44

merged 3 commits into from
Jan 12, 2022

Conversation

@Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 12, 2022

FIx #43

@Archmonger Archmonger requested a review from a team as a code owner January 12, 2022 04:47
@Archmonger Archmonger self-assigned this Jan 12, 2022
@Archmonger
Copy link
Contributor Author

Archmonger commented Jan 12, 2022

Not quite ready yet, looks like renaming the folder broke something with the JS build process. Will investigate in a moment.

@Archmonger Archmonger marked this pull request as draft January 12, 2022 05:42
@Archmonger Archmonger marked this pull request as ready for review January 12, 2022 07:47
@Archmonger Archmonger requested a review from rmorshea January 12, 2022 07:47
@Archmonger Archmonger merged commit 940fbe2 into reactive-python:main Jan 12, 2022
@Archmonger Archmonger deleted the static-folder-name branch January 12, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmorshea rmorshea Awaiting requested review from rmorshea

Assignees

@Archmonger Archmonger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix antipattern with static folder name

2 participants

@Archmonger @rmorshea