Skip to content

Commit 84e1246

Browse files
CopilotArchmonger
andauthored
Fix flaky test: ESM module loading race condition in test_subcomponent_notation (#1315)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Archmonger <16909269+Archmonger@users.noreply.github.com>
1 parent 2671e78 commit 84e1246

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

tests/test_reactjs/js_fixtures/subcomponent-notation.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
import React from "https://esm.sh/react@19.0"
2-
import ReactDOM from "https://esm.sh/react-dom@19.0/client"
3-
import {InputGroup, Form} from "https://esm.sh/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
1+
import React from "https://esm.sh/v135/react@19.0"
2+
import ReactDOM from "https://esm.sh/v135/react-dom@19.0/client"
3+
// Explicitly import react-is to ensure it's loaded before react-bootstrap
4+
// This prevents race conditions where react-bootstrap tries to use React context before deps are ready
5+
import * as ReactIs from "https://esm.sh/v135/react-is@19.0"
6+
import {InputGroup, Form} from "https://esm.sh/v135/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
47
export {InputGroup, Form};
58

69
export function bind(node, config) {

tests/test_web/js_fixtures/subcomponent-notation.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
import React from "https://esm.sh/react@19.0"
2-
import ReactDOM from "https://esm.sh/react-dom@19.0/client"
3-
import {InputGroup, Form} from "https://esm.sh/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
1+
import React from "https://esm.sh/v135/react@19.0"
2+
import ReactDOM from "https://esm.sh/v135/react-dom@19.0/client"
3+
// Explicitly import react-is to ensure it's loaded before react-bootstrap
4+
// This prevents race conditions where react-bootstrap tries to use React context before deps are ready
5+
import * as ReactIs from "https://esm.sh/v135/react-is@19.0"
6+
import {InputGroup, Form} from "https://esm.sh/v135/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
47
export {InputGroup, Form};
58

69
export function bind(node, config) {

0 commit comments

Comments
 (0)