InvokeCommand should call ExecuteAsync whenever possible.#700
Merged
Conversation
anaisbetts
pushed a commit
that referenced
this pull request
Aug 13, 2014
InvokeCommand should call ExecuteAsync whenever possible.
Member
|
👍, thanks! |
|
Again, an API break. What is the deal here, do we care about semver and API/ABI compat or not? |
Contributor
Author
|
So this PR is basically a bug fix for the problem where we cannot cleanup the subscription created by the call to Execute. You are right that this is indeed an API break, but a small one. We should do a 6.1 release I guess. Lets see what @paulcbetts thinks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvokeCommandstill callsExecutewhile we have the new awesomeExecuteAsyncmethod. This PR makesInvokeCommandcallExecuteAsync, so we properly cleanup theExecuteAsyncsubscription if we disposeInvokeCommand.