feature: enable reactiveui with system.reactive v4 #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
In theory, this is all that is needed to be done.
|
olevett
approved these changes
Jun 12, 2018
Contributor
|
Hi @olevett @ghuntley , I have to chime in here because I'm having some trouble using Rx 4 alongside RxUI 8.3.1 (for a short description, please see https://reactivex.slack.com/archives/C02AJB872/p1530353295000001 ) . Would you mind to explain this PR to me? For me the change looks like NOW RxUI is pinned to Version 3.1.1 of System.Reactive, as before any version from 3.1.1 to 4 could be used...thank you for explaining. |
Contributor
|
Before it meant use 3.11 but only allow projects to use below 4.0.0 using binding redirects without producing an error. |
Contributor
|
hey Glenn, thank you for the clarification and the Link in Slack! Much appreciated. |
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
System.Reactiveis pinned to v3.x, preventing installation of v4.xWhat is the new behavior (if this is a feature change)?
System.Reactiveis unpinned.What might this PR break?
Please check if the PR fulfills these requirements
Other information:
I have not tested this change; it's a pure find and replace.