Added Benchmark Harness (#1729) #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLittlesII
changed the title
Member
Author
|
A few things to point out.
|
glennawatson
requested changes
Aug 23, 2018
| }); | ||
| } | ||
|
|
||
| [Benchmark] |
Contributor
There was a problem hiding this comment.
I wonder if there is any penalty having the xunit fact in this file. I imagine that harness file getting pretty large
Member
Author
There was a problem hiding this comment.
Because it's xUnit and it should simply run all [Fact] in the project, we should be able to break up the harness files into smaller files in the future as needed.
| } | ||
|
|
||
| [Fact] | ||
| public void Reactive_List_Operation_Benchmark() |
Contributor
There was a problem hiding this comment.
Can you add my bench marks for the inpc property observable in the framework. In the pr I linked the other day.
- Added NavigationStack Benchmarks - Added AutoPersist Benchmarks - Added ReactiveList Operations Benchmarks - Added RoutableViewModelMixin Benchmarks
glennawatson
approved these changes
Aug 24, 2018
RLittlesII
changed the title
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Resolves #1711
Resolves #1276
What is the current behavior? (You can also link to an open issue here)
There are no performance tests
What is the new behavior (if this is a feature change)?
Adds a harness for ReactiveUI to execute performance benchmarks
What might this PR break?
Nothing. This PR is additive. Nothing in this PR affects the core solution.
Please check if the PR fulfills these requirements