feature: Add a constructor to take the constructor to RoutingState #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLittlesII
approved these changes
Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
The routing state has a Scheduler property, but to set the Scheduler it'll re-generate all the commands/observables all over again if you want to immediately change the scheduler.
Now we have a constructor overload which takes a scheduler and will only set these commands/observables once.
What is the current behavior? (You can also link to an open issue here)
That you use the property but this has a performance downside.
What is the new behavior (if this is a feature change)?
To keep the property if users need it, but just add a additional constructor for the user.
What might this PR break?
Shouldn't break users due to keeping existing API.