feature: Add app for the getting started guide #1740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
requested changes
Sep 2, 2018
Member
|
Is there a reason we are putting this in the main repository as opposed to a repository specifically for samples? |
Contributor
|
Pretty much everyone in the dev slack forum argued for main repository except for maybe yourself. I was a bit agnostic so going with the will of the people. |
Contributor
|
I think the motivation btw was that samples would he neglected if in a seperate repository. Also at one point we had about 3 sample repositories. |
Contributor
|
Also potentially another issue is there are more projects than just rxui in the RxUI organisation and only so much room to pin them with on the GitHub page. |
glennawatson
approved these changes
Sep 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds a sample app for the new Getting Started guide.
What is the current behavior? (You can also link to an open issue here)
There is no sample app in the main repository for the new Getting Started guide.
What is the new behavior (if this is a feature change)?
There is a sample app in the main repository for the new Getting Started guide.
What might this PR break?
Nothing.