Fix Xamarin.Forms RoutedViewHost exception #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLittlesII
approved these changes
Sep 7, 2018
glennawatson
approved these changes
Sep 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix (introduced in the migration from ReactiveList to DynamicData)
What is the current behavior? (You can also link to an open issue here)
Null reference exception when creating a Xamarin.Forms RoutedViewHost. Internally, the following exception was thrown by the line changed in this PR:
What is the new behavior (if this is a feature change)?
No more exception
What might this PR break?
Nothing
Please check if the PR fulfills these requirements
Other information: