samples: Add xamarin page routing and support various detail views (#1745) #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLittlesII
approved these changes
Sep 7, 2018
Member
RLittlesII
left a comment
RLittlesII
left a comment
There was a problem hiding this comment.
Out of curiosity, why the switch back to an explicit dependency on 8.7.2?
Contributor
Author
|
Ah I forgot to set it back after my RoutedViewHost fix. That fix should be included in MyGet now, right? And do you happen to know why the PR validation is failing? |
Member
|
PR validation is failing because the build is broken due to unit tests failing. Glenn was looking into it. |
Contributor
|
I been attempting to fix the PR validation while travellling, should have it sorted soon. |
glennawatson
changed the title
RLittlesII
changed the title
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
samples: Add xamarin page routing and support various detail views (#1745)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Improved master-detail sample
What is the current behavior? (You can also link to an open issue here)
Limited to only a single detail view and no navigation
What is the new behavior (if this is a feature change)?
Supports different detail views and includes navigation via RoutedViewHost
What might this PR break?
Nothing
Please check if the PR fulfills these requirements
Other information: