housekeeping: tidying of build warnings in event builder #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
approved these changes
Oct 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
housekeeping
What is the current behavior? (You can also link to an open issue here)
event builder has a couple of minor warnings
What is the new behavior (if this is a feature change)?
fix the warnings
What might this PR break?
one of the warnings was for having setters on
AssembliesandCecilSearchDirectories, which I've changed on the interface but this ended up needing a change on the Bespoke path. I don't think this should impact anything, but it's possible it might. Happy to think of alternatives/just ignore this warning though.Please check if the PR fulfills these requirements
Other information:
I've also just ignored the warnings about iOS, because they seemed slightly unreasonable