Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update to MSBuild.Sdk.Extras v2.0.24 and output API differences on DevOps builds. #2012

Merged
merged 7 commits into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

commented Apr 26, 2019

Update to the latest.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Apr 26, 2019

@olevett
Copy link
Member

left a comment

👍

@glennawatson

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

I made some changes to get this to work in the .net core 3 preview branch, will bring those across.

glennawatson added some commits Apr 26, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #2012 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
- Coverage   61.02%   60.92%   -0.11%     
==========================================
  Files         113      113              
  Lines        4565     4565              
  Branches      655      655              
==========================================
- Hits         2786     2781       -5     
- Misses       1598     1604       +6     
+ Partials      181      180       -1
Impacted Files Coverage Δ
src/ReactiveUI.Winforms/RoutedViewHost.cs 87.5% <0%> (-2.78%) ⬇️
src/ReactiveUI.Winforms/ViewModelViewHost.cs 89.32% <0%> (-1.95%) ⬇️
src/ReactiveUI/RxApp.cs 81.33% <0%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612f468...e97a58e. Read the comment docs.

glennawatson added some commits Apr 27, 2019

@glennawatson glennawatson requested review from reactiveui/winforms-team as code owners Apr 27, 2019

@glennawatson glennawatson changed the title housekeeping: Update to MSBuild.Sdk.Extras v2.0.24 housekeeping: Update to MSBuild.Sdk.Extras v2.0.24 and output API differences on DevOps builds. Apr 27, 2019

@glennawatson glennawatson merged commit a1cb284 into master Apr 27, 2019

5 of 6 checks passed

codecov/project 60.92% (-0.11%) compared to 612f468
Details
ReactiveUI-CI Build #9.13.15+986ad81613 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing 612f468...e97a58e
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-patch-1 branch Apr 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.