Skip to content

Conversation

@glennawatson
Copy link
Contributor

Update to the latest.

@glennawatson glennawatson requested a review from a team April 26, 2019 05:12
Copy link
Member

@olevett olevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@glennawatson
Copy link
Contributor Author

I made some changes to get this to work in the .net core 3 preview branch, will bring those across.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #2012 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
- Coverage   61.02%   60.92%   -0.11%     
==========================================
  Files         113      113              
  Lines        4565     4565              
  Branches      655      655              
==========================================
- Hits         2786     2781       -5     
- Misses       1598     1604       +6     
+ Partials      181      180       -1
Impacted Files Coverage Δ
src/ReactiveUI.Winforms/RoutedViewHost.cs 87.5% <0%> (-2.78%) ⬇️
src/ReactiveUI.Winforms/ViewModelViewHost.cs 89.32% <0%> (-1.95%) ⬇️
src/ReactiveUI/RxApp.cs 81.33% <0%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612f468...e97a58e. Read the comment docs.

@glennawatson glennawatson requested review from a team April 27, 2019 06:25
@glennawatson glennawatson changed the title housekeeping: Update to MSBuild.Sdk.Extras v2.0.24 housekeeping: Update to MSBuild.Sdk.Extras v2.0.24 and output API differences on DevOps builds. Apr 27, 2019
@glennawatson glennawatson merged commit a1cb284 into master Apr 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-patch-1 branch April 27, 2019 06:44
@lock lock bot locked and limited conversation to collaborators Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants