Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Added IBuilder and Extensions #2019

Merged
merged 4 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@RLittlesII
Copy link
Member

commented May 6, 2019

  • Moved extensions to correctly named files

What kind of change does this PR introduce?

Adds IBuilder and extensions for building objects.

What is the current behavior?

This currently isn't part of ReactiveUI.Testing

What is the new behavior?

You can now use the IBuilder and extensions by sourcing ReactiveUI.Testing

What might this PR break?

Nothing.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@RLittlesII RLittlesII requested a review from reactiveui/core-team as a code owner May 6, 2019

@codecov

This comment has been minimized.

Copy link

commented May 6, 2019

Codecov Report

Merging #2019 into master will decrease coverage by 0.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
- Coverage      61%   60.78%   -0.23%     
==========================================
  Files         113      115       +2     
  Lines        4565     4580      +15     
  Branches      655      656       +1     
==========================================
- Hits         2785     2784       -1     
- Misses       1598     1614      +16     
  Partials      182      182
Impacted Files Coverage Δ
src/ReactiveUI.Testing/SchedulerExtensions.cs 58.69% <ø> (ø)
src/ReactiveUI.Testing/MessageBusExtensions.cs 0% <0%> (ø)
src/ReactiveUI.Testing/IBuilderExtensions.cs 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fdca69...3cdd6e6. Read the comment docs.

housekeeping: Added IBuilder and Extensions
- Moved extensions to correctly named files

@RLittlesII RLittlesII force-pushed the feature/builder branch from a675c7f to 57ef55c May 6, 2019

RLittlesII added some commits May 6, 2019

@glennawatson glennawatson merged commit 7da21d1 into master May 7, 2019

4 of 6 checks passed

codecov/patch 0% of diff hit (target 61%)
Details
codecov/project 60.78% (-0.23%) compared to 8fdca69
Details
ReactiveUI-CI Build #9.13.13+8952b62e1d succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the feature/builder branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.