Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WhenActivated on WPF by reverting to MsBuild.Sdk.Extras 1.6.18 #2027

Merged
merged 2 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

commented May 13, 2019

Downgrade to MsBuild.Sdk.Extras 1.6.68 since it was preventing WhenActivated was firing.

This should fix #2021

@glennawatson glennawatson requested review from reactiveui/core-team as code owners May 13, 2019

@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #2027 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2027   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         116      116           
  Lines        4448     4448           
  Branches      638      638           
=======================================
  Hits         2677     2677           
  Misses       1598     1598           
  Partials      173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe8498...9c7b976. Read the comment docs.

@glennawatson glennawatson merged commit 3cf59ab into master May 13, 2019

6 checks passed

ReactiveUI-CI Build #9.15.3+e361d7572e succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing dfe8498...9c7b976
Details
codecov/project 60.18% remains the same compared to dfe8498
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the issue-2021-b branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.