Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add Universal Windows routing example #2030

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
2 participants
@worldbeater
Copy link
Member

commented May 13, 2019

What kind of change does this PR introduce?

This PR adds a basic Universal Windows Platform routing example powered by ReactiveUI.

What is the current behavior?

There are no UWP sample apps now in the samples directory.

What is the new behavior?

A new UWP sample app is added, showing up ReactiveUI routing (with animations)

What might this PR break?

Nothing.

@worldbeater worldbeater marked this pull request as ready for review May 13, 2019

@worldbeater worldbeater requested a review from reactiveui/core-team as a code owner May 13, 2019

@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #2030 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2030   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         116      116           
  Lines        4448     4448           
  Branches      638      638           
=======================================
  Hits         2677     2677           
  Misses       1598     1598           
  Partials      173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf59ab...84c05e5. Read the comment docs.

@worldbeater worldbeater merged commit 97d1aa3 into master May 13, 2019

6 checks passed

ReactiveUI-CI Build #9.15.3+4ce60bee06 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing 3cf59ab...84c05e5
Details
codecov/project 60.18% remains the same compared to 3cf59ab
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the uwp-routing-example branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.