Suppress binding warnings for BindCommand on WPF #2037 #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
glennawatson
approved these changes
May 19, 2019
madmonkey
pushed a commit
to madmonkey/ReactiveUI
that referenced
this pull request
Jul 12, 2019
* Suppress binding warnings for BindCommand on WPF Fixes reactiveui#2037
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
BindCommand will output warnings when binding ViewModel command to view button on WPF #2037
What is the new behavior?
Warnings are suppressed for the specific scenario.
What might this PR break?
API approval tests
Please check if the PR fulfills these requirements
Other information: