Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress binding warnings for BindCommand on WPF #2037 #2039

Merged
merged 2 commits into from May 19, 2019

Conversation

Projects
None yet
3 participants
@mgnslndh
Copy link
Contributor

commented May 19, 2019

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
BindCommand will output warnings when binding ViewModel command to view button on WPF #2037

What is the new behavior?
Warnings are suppressed for the specific scenario.

What might this PR break?
API approval tests

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@mgnslndh mgnslndh requested review from reactiveui/android-team as code owners May 19, 2019

@dnfclas

This comment has been minimized.

Copy link

commented May 19, 2019

CLA assistant check
All CLA requirements met.

@glennawatson glennawatson merged commit 39aca80 into reactiveui:master May 19, 2019

4 checks passed

ReactiveUI-CI Build #9.15.7+dfa5fbdabf succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.