Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uno not including ReactiveUI NuGet package #2091

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

commented Jun 27, 2019

  • Changed so that the ReactiveUI.Uno.csproj now references ReactiveUI.csproj
  • Change UAP/Windows Common to put items into the ReactiveUI.Uno if HAS_UNO is defined.
  • Don't register the WinRTAppDataDriver for Uno at the moment until we work out the replacement methods that aren't implemented in Uno, these are
    WinRTAppDataDriver.cs(32,34): warning Uno0001: Windows.Storage.FileIO.ReadTextAsync(Windows.Storage.IStorageFile, Windows.Storage.Streams.UnicodeEncoding) is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]
     WinRTAppDataDriver.cs(32,58): warning Uno0001: Windows.Storage.Streams.UnicodeEncoding.Utf8 is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]
     WinRTAppDataDriver.cs(71,61): warning Uno0001: Windows.Storage.StorageFile.DeleteAsync() is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]
     WinRTAppDataDriver.cs(59,65): warning Uno0001: Windows.Storage.FileIO.WriteBytesAsync(Windows.Storage.IStorageFile, byte[]) is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]
    

Perhaps @jeromelaban knows good alternative methods.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Jun 27, 2019

@RLittlesII
Copy link
Member

left a comment

LGTM.

@RLittlesII RLittlesII merged commit 7d16f20 into master Jun 27, 2019

4 checks passed

ReactiveUI-CI Build #9.17.17+af756a16ad succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-uno branch Jun 27, 2019

madmonkey added a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.