Skip to content

fix: uno not including ReactiveUI NuGet package #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

fix: uno not including ReactiveUI NuGet package #2091

merged 1 commit into from
Jun 27, 2019

Conversation

@glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Jun 27, 2019

  • Changed so that the ReactiveUI.Uno.csproj now references ReactiveUI.csproj
  • Change UAP/Windows Common to put items into the ReactiveUI.Uno if HAS_UNO is defined.
  • Don't register the WinRTAppDataDriver for Uno at the moment until we work out the replacement methods that aren't implemented in Uno, these are 
    WinRTAppDataDriver.cs(32,34): warning Uno0001: Windows.Storage.FileIO.ReadTextAsync(Windows.Storage.IStorageFile, Windows.Storage.Streams.UnicodeEncoding) is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]
 WinRTAppDataDriver.cs(32,58): warning Uno0001: Windows.Storage.Streams.UnicodeEncoding.Utf8 is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]
 WinRTAppDataDriver.cs(71,61): warning Uno0001: Windows.Storage.StorageFile.DeleteAsync() is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]
 WinRTAppDataDriver.cs(59,65): warning Uno0001: Windows.Storage.FileIO.WriteBytesAsync(Windows.Storage.IStorageFile, byte[]) is not implemented in Uno [C:\source\reactiveui\ReactiveUI\src\ReactiveUI.Uno\ReactiveUI.Uno.csproj]

Perhaps @jeromelaban knows good alternative methods.

@glennawatson glennawatson requested review from a team June 27, 2019 03:50
RLittlesII
RLittlesII approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@RLittlesII RLittlesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RLittlesII RLittlesII merged commit 7d16f20 into master Jun 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-uno branch June 27, 2019 04:09
madmonkey pushed a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019
@glennawatson @madmonkey
fix: uno not including ReactiveUI NuGet package (reactiveui#2091)
cca7d88
@glennawatson glennawatson restored the glennawatson-fix-uno branch August 15, 2019 05:18
@glennawatson glennawatson deleted the glennawatson-fix-uno branch August 15, 2019 05:51
@lock lock bot locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RLittlesII RLittlesII RLittlesII approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glennawatson @RLittlesII