fix: added constructors required by Uno.UI for Android and iOS. #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
https://github.com/reactiveui/ReactiveUI/blob/master/src/Directory.build.targets use the constants in that file rather than the others.
|
glennawatson
requested changes
Jul 9, 2019
glennawatson
reviewed
Jul 9, 2019
weitzhandler
changed the title
glennawatson
reviewed
Jul 9, 2019
glennawatson
approved these changes
Jul 9, 2019
Contributor
|
Cool thanks, looking good now. |
madmonkey
pushed a commit
to madmonkey/ReactiveUI
that referenced
this pull request
Jul 12, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes missing constructors by Uno.UI.
What is the current behavior?
Uno complains about these missing constructors.
What is the new behavior?
Adds bridge constructors in the intermediate classes.
What might this PR break?
None
Please check if the PR fulfills these requirements
@jeromelaban Please have a look