Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added constructors required by Uno.UI for Android and iOS. #2116

Merged
merged 6 commits into from Jul 9, 2019

Conversation

Projects
None yet
2 participants
@weitzhandler
Copy link
Contributor

commented Jul 9, 2019

What kind of change does this PR introduce?
Fixes missing constructors by Uno.UI.

What is the current behavior?
Uno complains about these missing constructors.

What is the new behavior?
Adds bridge constructors in the intermediate classes.

What might this PR break?
None

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jeromelaban Please have a look

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

https://github.com/reactiveui/ReactiveUI/blob/master/src/Directory.build.targets use the constants in that file rather than the others.

GitHub
An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable st...

weitzhandler added some commits Jul 9, 2019

@weitzhandler weitzhandler changed the title fix: Added constructors required by Uno.UI for Android and iOS. fix: added constructors required by Uno.UI for Android and iOS. Jul 9, 2019

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Cool thanks, looking good now.

@weitzhandler weitzhandler marked this pull request as ready for review Jul 9, 2019

@weitzhandler weitzhandler requested review from reactiveui/uwp-team as code owners Jul 9, 2019

@glennawatson glennawatson merged commit 780e446 into reactiveui:master Jul 9, 2019

2 checks passed

ReactiveUI-CI Build #9.18.21+a93ba89f9d succeeded
Details
license/cla All CLA requirements met.
Details

madmonkey added a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.