Skip to content

Conversation

@ghuntley
Copy link
Member

@ghuntley ghuntley commented Aug 16, 2019

What kind of change does this PR introduce?

Minor lipstick.

What might this PR break?

If I dorked up the XML in the GitHub editor then this PR won't build, if it builds then 🚢 unless touchups required.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link
Member

@olevett olevett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me :)

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #2134 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
- Coverage   58.84%   58.82%   -0.03%     
==========================================
  Files         117      117              
  Lines        4760     4760              
  Branches      740      740              
==========================================
- Hits         2801     2800       -1     
  Misses       1727     1727              
- Partials      232      233       +1
Impacted Files Coverage Δ
src/ReactiveUI/RxApp.cs 81.57% <0%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c622e...aaa2ea1. Read the comment docs.

@glennawatson glennawatson merged commit 2c81339 into master Aug 20, 2019
@glennawatson glennawatson deleted the ghuntley-patch-1 branch August 20, 2019 03:10
@lock lock bot locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants