Housekeeping: update contribution guide to mention master #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update target base branch when submitting a pull request like spoken in reactiveui#2164 (reactiveui#2164 (comment))
glennawatson
approved these changes
Oct 1, 2019
Contributor
glennawatson
left a comment
glennawatson
left a comment
There was a problem hiding this comment.
Awesome thanks for doing this.
glennawatson
changed the title
worldbeater
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs Update => Update target base branch when submitting a pull request like spoken in (#2164 (comment))
What is the current behavior?
Wrong target base branch
What is the new behavior?
What might this PR break?
Nothing
Please check if the PR fulfills these requirements
Other information: